Feature: location payload#34
Merged
Merged
Conversation
Contributor
|
Contributor
Author
|
Contributor
|
Yeah I'm totally for |
Contributor
Author
|
@zenangst |
Contributor
Contributor
|
This is good 🎉 |
Contributor
Author
|
@onmyway133 |
Contributor
|
@onmyway133 any suggestions? otherwise I'll just go ahead and merge this bad-boi |
Contributor
|
@zenangst I think you can go ahead |
Contributor
|
AAAA YEAH! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@zenangst @onmyway133 @RamonGilabert
Mappablelike in Feature: mappable meta Brick#12 it addsTailoras a dependency and could lead to many small struct types in the project codebase. My solution here is to add a new property onLocation:Since it's
Anywe can pass whatever we want and then cast it to the type that we expect:payloadproperty, do we needfragmentsat all? Because you can set[String: AnyObject]dictionary as payload. The only disadvantage is that you have to cast it later:Routablethat will be caught inRouterand handled by a new type calledErrorRoutable. It means we can present some error screen when the route is not found or arguments are invalid.